Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: externalize MapieClassifier methods into several non-conformity scores #476

Merged
merged 46 commits into from
Jul 17, 2024

Conversation

thibaultcordier
Copy link
Collaborator

@thibaultcordier thibaultcordier commented Jul 1, 2024

Description

Outsource the MapieClassifier methods (LAC, APS, RAPS, TOPK) by extending the non-conformity score class to the classification task.

Fixes #467

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test that existing code continues to work
  • Test that the proposed solution can enable new non-conformity scores

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@thibaultcordier thibaultcordier added Enhancement Type: enhancement (new feature or request) Source: developers Proposed by developers. labels Jul 1, 2024
@thibaultcordier thibaultcordier self-assigned this Jul 1, 2024
@thibaultcordier thibaultcordier linked an issue Jul 1, 2024 that may be closed by this pull request
@thibaultcordier thibaultcordier changed the title UPD: externalize MapieClassifier methods into several non-conformity scores ENH: externalize MapieClassifier methods into several non-conformity scores Jul 1, 2024
@thibaultcordier thibaultcordier marked this pull request as ready for review July 3, 2024 16:20
@vincentblot28
Copy link
Collaborator

What a tour de force @thibaultcordier !! Great improvement to the classification API !
General comment about the example: as in the future we prefer to use directly the conformity scores (and the argument "method" might be removed) I think examples should follow the new way of using MapieClassifier

@thibaultcordier thibaultcordier merged commit e7be313 into master Jul 17, 2024
8 checks passed
@Valentin-Laurent Valentin-Laurent deleted the 467-ncs-classification branch November 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Type: enhancement (new feature or request) Source: developers Proposed by developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending the NCS class to the classification task
5 participants