Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature encoding algorithms (Fisher vector, VLAD, and BoW) #21

Open
DavidTorpey opened this issue Jul 17, 2019 · 1 comment
Open

Comments

@DavidTorpey
Copy link

I was wondering if it would be possible to include the three main popular feature encoding / pooling / quantisation algorithms into scikit-learn, namely, Fisher vectors, VLAD, and BoW. They are very popular, time-tested algorithms with many applications.

I am happy to submit this feature as well.

Originally proposed for scikit-learn, and was suggested instead to go into this library:
scikit-learn/scikit-learn#14382

@adrinjalali
Copy link
Member

Hmm, I think the idea here was to include methods which don't pass the inclusion criteria, but the issue with these methods is the API.

I think it wouldn't hurt to be a bit more liberal with the API in this repo, but not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants