use string_veiw

scivision · Jul 23, 2024 · e371232 · e371232
1 parent 0f4ec1f
commit e371232
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/ffilesystem.cpp b/src/ffilesystem.cpp
@@ -18,7 +18,7 @@ size_t fs_char2char(const char* in, char* out, size_t buffer_size)
 }
 
 
-size_t fs_str2char(std::string in, char* out, size_t buffer_size)
+size_t fs_str2char(std::string_view in, char* out, size_t buffer_size)
 {
   // string to char*, for Fortran interface
   if(in.length() >= buffer_size){

diff --git a/src/ffilesystem.h b/src/ffilesystem.h
@@ -2,7 +2,7 @@
 extern "C" {
 #endif
 
-size_t fs_str2char(std::string, char*, size_t);
+size_t fs_str2char(std::string_view, char*, size_t);
 size_t fs_char2char(const char*, char*, size_t);
 
 #ifdef __cplusplus

diff --git a/test/case_sensitive/case_sensitive.cpp b/test/case_sensitive/case_sensitive.cpp
@@ -13,7 +13,7 @@ namespace fs = std::filesystem;
 // Discussion of general issues across operating systems.
 // https://github.com/dotnet/runtime/issues/14321
 
-bool is_case_sensitive(std::string drive){
+bool is_case_sensitive(std::string_view drive){
 // https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getvolumeinformationa
 
   if (drive.empty())
@@ -25,7 +25,7 @@ bool is_case_sensitive(std::string drive){
   DWORD lpFileSystemFlags=0;
 
   if(!GetVolumeInformationA(drive.c_str(), 0, 0, 0, 0, &lpFileSystemFlags, 0, 0))
-    throw std::runtime_error("GetVolumeInformation: " + drive + " " + std::system_category().message(GetLastError()));
+    throw std::runtime_error("GetVolumeInformation: " + std::system_category().message(GetLastError()));
 
   return bool(FILE_CASE_SENSITIVE_SEARCH & lpFileSystemFlags);
 }

diff --git a/test/is_exe/test_is_exe.cpp b/test/is_exe/test_is_exe.cpp
@@ -4,7 +4,7 @@
 
 namespace fs = std::filesystem;
 
-bool fs_is_exe(std::string path)
+bool fs_is_exe(std::string_view path)
 {
 
   fs::path p(path);