Add 10.5 #145
Add 10.5 #145
Conversation
|
[test] |
2 similar comments
|
[test] |
|
[test] |
|
The Fedora failure is very interesting, leads to https://bugzilla.redhat.com/show_bug.cgi?id=1914984 that is a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=1908281. |
|
Addresses #112. |
|
[test] |
1 similar comment
|
[test] |
|
@hhorak Thanks for the PR and driving it! Can you please update also image streams for CentOS7 at least? |
10.5/cccp.yml
Outdated
| @@ -0,0 +1 @@ | |||
| job-id: mariadb-103-centos7 | |||
There was a problem hiding this comment.
I guess, it should be mariadb-105-centos7, right?
root-common/usr/share/container-scripts/mysql/init/40-datadir-action.sh
Outdated
Show resolved
Hide resolved
|
I guess devel-repos should be mentioned in version |
|
If it is feasible now, please update also main README.md file with build reference to quay.io repository which already exists https://quay.io/repository/centos7/mariadb-105-centos7/status |
…repo defined by DEVEL_REPO_rhelX variable
Most important is using --auth-root-authentication-method=normal which changed the default value since 10.5 and while we don't use root acount inside the container, we cannot use the new functionality that depends on being a superuser after initialization of the datadir. The replication test changes check of whether the slave has data from the master.
From some unknown reason this makes the user permissions not being replicated on 10.5 and further. It seems that filtering on mysql name was not supposed to be working anyway according to https://jira.mariadb.org/browse/MDEV-5704 And there were some changes done in 10.4 that might be related: https://jira.mariadb.org/browse/MDEV-17658 Anyway, there is probably no reason to limit the databases replicated by default.
|
Rebased, let's try tests again. |
|
[test] |
|
Let's restart tests because of sclorg/rhscl-container-ci#76 [test] |
|
@hhorak Tests are passing, but there are some issues that should be solved, I guess. Please take a look on my comments. Thanks. |
Right, makes sense.
Cool, will add it there. |
|
[test] |
|
I've created a separate PR for updating imagestreams, as we likely should merge those only after the images are released: |
|
LGTM. Thanks for updating issues. |
|
Merging... Tadaaaaaaaa |
|
@hhorak I see this PR added |
This uses a new feature of "devel repos" as more described in sclorg/container-common-scripts#186. Therefore, that PR should be merged before this one.
Except adding sources for 10.5 version, these are other changes done to make the 10.5 working:
From some unknown reason, listing the DBs to be replicated made the user permissions not being replicated on 10.5
It seems that filtering on mysql name was not supposed to be working anyway according to https://jira.mariadb.org/browse/MDEV-5704
And there were some changes done in 10.4 that might be related: https://jira.mariadb.org/browse/MDEV-17658
Anyway, there is probably no reason to limit the databases replicated by default.
Using
--auth-root-authentication-method=normalwhen initiating DB, which changed the default value since 10.5 and because we don't use root account inside the container, we cannot use the new functionality that depends on being a superuser after initialization of the datadir.Templates not updated because RPMs are not yet available, the new version is also not list in the main README.md yet.