Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the repository. #209

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Cleaning up the repository. #209

merged 4 commits into from
Jul 27, 2023

Conversation

@zmiklank
Copy link
Contributor Author

[test]

@zmiklank
Copy link
Contributor Author

[test]

@zmiklank
Copy link
Contributor Author

I tried to find out why the weak deps of mariadb-server were not installed. But with no success.
The /etc/dnf/dnf.conf file in the Fedora 10.5 image is as follows:

bash-5.2$ cat /etc/dnf/dnf.conf
# see `man dnf.conf` for defaults and possible options

[main]
gpgcheck=True
installonly_limit=3
clean_requirements_on_remove=True
best=False
skip_if_unavailable=True
tsflags=nodocs

And also we do not explicitly use --setopt=install_weak_deps=False when installing packages.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@zmiklank
Copy link
Contributor Author

Let's wait for opinion on the weak deps of @FaramosCZ before merging this.

@FaramosCZ
Copy link

FaramosCZ commented Jul 25, 2023

I understood, that the previous version of the container content was built on top of Fedora 35: 6f493ba
And on the Fedora 35, the package installation worked as expected.

I've tried to use Fedora 37, on which the package installation worked as expected.
I've also tried quay.io/fedora/s2i-core:latest (which contained Fedora 38 at the time I tested it), on which the package installation worked as expected.

I've managed to reproduce the issue only on the quay.io/fedora/s2i-core:37.

podman run -ti quay.io/fedora/s2i-core:37 bash
yum -y module enable mariadb:10.5
dnf install --setopt=tsflags=nodocs policycoreutils rsync tar gettext hostname bind-utils groff-base mariadb-server

The problem is twofold.
Not only the mariadb-server-utils package is not brought in, as it should:
https://src.fedoraproject.org/rpms/mariadb/blob/rawhide/f/mariadb.spec#_429
The community-mysql package is brought in as the mysql client, instead of mariadb package.

I don't know why.


Since the issue does not occur on the Fedora 37, it may be an issue that was present for short time during Fedora 37 life, is fixed now in Fedora 37, but it persists in the quay.io/fedora/s2i-core:37 image.
Could you update the image and check if the issue persists ?

Or it may be other issue exclusive to the quay.io/fedora/s2i-core:37 image.
Was is crafted correctly ?

And since on 2023-04-18 the Fedora 38 was released, I'd suggest to use Fedora 38 container image instead.
The issue is not present here (please double check, though), and you get all of the bonuses of newer OS release as well.


Side note:
I guessed that some file conflict between community-mysql, community-mysql-common and mariadb-server-utils is the reason for mariadb-server-utils not being installed, but I haven't found any.
The dnf install community-mysql community-mysql-common mariadb-server-utils command succeeds both in a VM and in the quay.io/fedora/s2i-core:37 image.

The cross-installation functionality when you can install mysql client for mariadb server and vice versa, is planned to be dropped in future by me.
It might help to avoid issues like this in the future, even though I doubt the cross-installation is the root cause of what we're seeing.

@zmiklank
Copy link
Contributor Author

I've managed to reproduce the issue only on the quay.io/fedora/s2i-core:37.

This is interesting fact. I have checked changes in s2i-core image between migration from f35->f36->f37->f38 and they were none, except of bumping the version itself.

Since the issue does not occur on the Fedora 37, it may be an issue that was present for short time during Fedora 37 life, is fixed now in Fedora 37, but it persists in the quay.io/fedora/s2i-core:37 image. Could you update the image and check if the issue persists ?

It occurred to me too. The s2i-core and s2i-base are being rebuilt every Tuesday so if I remove explicit installation of mariadb-server-utils and re-run the tests they will be run on fresh image, so we will see if the thing is fixed.

And since on 2023-04-18 the Fedora 38 was released, I'd suggest to use Fedora 38 container image instead. The issue is not present here (please double check, though), and you get all of the bonuses of newer OS release as well.

Agreed. Will do that.

Thank you very much for such a insightful feedback!

@zmiklank
Copy link
Contributor Author

[test]

@zmiklank
Copy link
Contributor Author

It occurred to me too. The s2i-core and s2i-base are being rebuilt every Tuesday so if I remove explicit installation of mariadb-server-utils and re-run the tests they will be run on fresh image, so we will see if the thing is fixed.

Actually I just realized this applies only for f38 s2i-core. In that case I would mark the s2i-core:37 as no longer supported and migrate to f38 straight away.

@zmiklank
Copy link
Contributor Author

[test]

@zmiklank
Copy link
Contributor Author

I have rebuilt the s2i-core:f37 out of curiosity on my localhost. And the issue was no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants