Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New client features and fixes #11

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

EnPassant4264
Copy link
Contributor

@EnPassant4264 EnPassant4264 commented Oct 24, 2023

Item features (will be proposing these to main):

  • Ratings: Mods can define whether an item is Popular, regular, usually useless, useless, or Pokemon-specific
    -- All custom Mega Stones and items with an itemUser defined default to Pokemon-specific like the real items do
    -- (minor) Booster Energy is now classified as specific to Paradox Pokemon
  • Individual mod isNonstandard changes now display in teambuilder

Move useful/useless:

  • The short and easy way: Adding viable: true/false to a move will force it to be one or the other. If not present, it defaults to the usual algorithm.
  • The long and thorough way: Mods can now add their own version of the moveIsNotUseless function (and the four tables it uses, if desired) to their teambuilderConfig. After the normal function is run, the mod's version will be, and it will override only if it returns a value for that move.

Fixes:

  • Sketch properly includes a mod's new and removed moves and can follow the same usefulness features
  • Script-altered Uber additions now reflect the bans on alternate formes in Pokemon selection
  • Gen 1 tradebacks correctly appear when searching Pokemon by move.

I tested the hell out of this in mods of as many types as should be affected (ones with Megas, National Dex mods, past gen mods, Gen 2 Doubles since it acts uniquely, and of course Earth & Sky since it makes changes for everything under the sun), including after transferring and pushing the changes on the DH side.

Mod-specific item lists (will be bringing these to main), mods can add their own moveIsNotUseless function, Tradeback search fix
@Rezzo64
Copy link
Collaborator

Rezzo64 commented Oct 28, 2023

if I can ever find time I will test all of this locally as well. But at a glance this looks fine to me

@Rezzo64 Rezzo64 merged commit accfae4 into scoopapa:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants