INHERITING SPRITES/CRIES IS BECOMING REAL #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we might not need this feature too much for now, maybe later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You just plop an "inherit" file with JSON formatting in a specified cries/sprites folder and if a mon has an entry in that file but does not have a sprite or cry in the same directory then it will look at whatever is listed for its entry and copy that thing's sprite or cry. (basically the other files in that directory override inherit file entries)
Also "substitute" mons with cry data actually play that cry data so the dependencies between cries and actual sprite data are now completely severed and retrieval of cry data has been moved into its own function, if custom cries aren't showing up chances are there was incorrect indexing and that should be fixed