Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix: Do not substitute strings without brackets #23

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix: Do not substitute strings without brackets #23

merged 1 commit into from
Jul 24, 2023

Conversation

ghen
Copy link
Contributor

@ghen ghen commented Jul 23, 2023

Fix to pass through strings without brackets, e.g. $abc -> $abc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@ghen
Fix: Do not substitute strings without brackets
ae09cff 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
@ghen ghen requested a review from chrishumanitec July 23, 2023 15:57
@ghen ghen merged commit edd5b26 into main Jul 24, 2023
3 checks passed
@ghen ghen deleted the feature/templates-fix branch July 24, 2023 19:31
chrishumanitec
chrishumanitec approved these changes Jul 24, 2023
View reviewed changes
Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a second issue to cover consistency in escaping.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrishumanitec chrishumanitec chrishumanitec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghen @chrishumanitec