-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker file fails to compile #144
Comments
Adding @NickSwainston to this since I'm a Docker noob. I'm playing around with it now, though, |
You want to run the command from the base repo directory, not the docker directory, like so |
Thanks @NickSwainston ! Now it fails because it doesn't find png.h, but this is weird, we are installing libpng-dev. Can it be due to some version mismatch?
|
@NickSwainston So I'm curious about this. I looked at the The only thing you need on Ubuntu PGPLOT-wise is the following environment variable set before you compile PRESTO:
And, one other thing. I tested installing full PRESTO on a completely clean Ubuntu 20.04 last year, and this command gets all of the packages needed for compilation and running:
|
I just made a pull request (#145) that fixes the bug and address your comments. I no longer install pgplot from scratch. I think I only did this because I got errors due to the missing PGPLOT_DIR environmental variable. I also removed tempo2 to make the image as minimal as possible, as I can add that in my version of the image. |
It worked!
Thanks @NickSwainston! @scottransom, do you think it would be possible to get this built on Docker Hub or similar? This would save a lot of time to users and, also, allow to use it straight away in cloud computing environments. |
Sounds like a great idea to me, although since I haven't been a Docker user I have no idea what that entails. I can poke around. But if you guys have ideas, please let me know! |
It is fairly easy. You start by creating a Docker Hub repo, e.g.
and log in from your Docker client. Once you build the software locally, you can tag it
and push to Docker Hub as I did here:
That's it! |
Hmmm. This doesn't seem to be working for me. I'm getting a GLIBC error when the build tries to run the test code:
|
Ah-ha... I think I see the issue. My system is running Ubuntu 21.04, but the Docker build is for Ubuntu 20.04. During the build, docker saw that my PRESTO C-libraries were already compiled, and so it simply copied the PRESTO stuff into the docker without rebuilding. But that is with a different GLIBC. So I think need to force a "make cleaner" in the Docker build to prevent that. I'll see if I can make the patch and test it. |
Another question: many of the PRESTO applications bring up x-windows and need X-based interactivity. What is the recommended way to do that? I'm seeing a ton of possible solutions, none of which seem really straightforward and really depend on what your main system (i.e. OS) is running. |
I also made an error when executing dockerfile. My error occurred when installing tempo, as shown in the figure. `>Step 18/22 : RUN git clone git://github.com/nanograv/tempo.git && cd tempo && ./prepare && ./configure && make && make install Tempo is ready to be compiled. Please run 'make'. 'make install' will copy 'tempo' to /usr/local/bin. Making all in src 46 | do 20 i=1,4 123 | 20 trb(i)=-d2bar 46 | do 20 i=1,4 50 | real10 frb, tt0, tt, orbits |
I tried to build the docker image by running
in the docker directory, but it fails with
The text was updated successfully, but these errors were encountered: