Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python runner stderr fix for crashlog() #895

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

S4adam
Copy link
Collaborator

@S4adam S4adam commented Jul 4, 2023

What?
A custom, simple class to write to 2 stderr channels (explained down below).

Why?
Currently, Python runner does not produce errors to Crashlog(), but only and only to si inst stderr, so the aim is to capture and redirect errors from stderr to both the process's stderr and the Instance's stderr endpoint (so that they are shown in both crashlog and inst stderr).

Usage:
You need to build, and use a custom runner-py docker image:

  1. Clone this pr:D

  2. docker build --pull --rm -f "packages/python-runner/Dockerfile" -t runner:v1 "./"

  3. yarn start:dev --runner-py-image=runner:v1

  4. Deploy any Python Sequence that produces an exception, example Sequence: crash-py.tar.gz.
    si seq deploy crash-py.tar.gz

  5. Verify that you can see the Exception message both in Transform Hub's Crashlog and Instance's stderr (as shown below):
    crashlog

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation (please post a screenshot)
  • All STH tests pass
  • All Scramjet Cloud Platform tests pass
  • Documentation is updated or no changes

https://app.clickup.com/t/24308805/VDM-993

@S4adam S4adam requested a review from gierwialo July 4, 2023 09:02
@S4adam S4adam merged commit 88a7775 into devel Jul 4, 2023
57 checks passed
@S4adam S4adam deleted the fix/runner-py-stderr branch July 4, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants