Python runner stderr fix for crashlog() #895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A custom, simple class to write to 2 stderr channels (explained down below).
Why?
Currently, Python runner does not produce errors to Crashlog(), but only and only to
si inst stderr
, so the aim is to capture and redirect errors from stderr to both the process's stderr and the Instance's stderr endpoint (so that they are shown in both crashlog and inst stderr).Usage:
You need to build, and use a custom runner-py docker image:
Clone this pr:D
docker build --pull --rm -f "packages/python-runner/Dockerfile" -t runner:v1 "./"
yarn start:dev --runner-py-image=runner:v1
Deploy any Python Sequence that produces an exception, example Sequence: crash-py.tar.gz.
si seq deploy crash-py.tar.gz
Verify that you can see the Exception message both in Transform Hub's Crashlog and Instance's stderr (as shown below):
Review checks:
These aspects need to be checked by the reviewer:
https://app.clickup.com/t/24308805/VDM-993