-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch auto field stats to an item pipeline #216
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 97.86% 98.03% +0.16%
==========================================
Files 14 16 +2
Lines 1590 1625 +35
Branches 337 342 +5
==========================================
+ Hits 1556 1593 +37
+ Misses 14 11 -3
- Partials 20 21 +1
|
The code looks good 👍 But I haven't checked how it works, and if it solves the issue :) |
logger = getLogger(__name__) | ||
|
||
|
||
class ScrapyZyteAPIAutoFieldStatsItemPipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving it to scrapy-poet might allow to make the name shorter :)
I was asked to support non-standard, custom items for auto field stats.
To achieve that, it seemed easier to switch the implementation to an item pipeline.
It also feels like this feature would make sense in scrapy-poet now. But I am not 100% sure, and I also would not want to move it until scrapy-poet gained add-on support.
To do:
setup.py
andtox.ini
accordingly.