feat(3128): Allow user to define new jobs which are not part of the pipeline template [2] #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| } | ||
| if (!isEmpty(oldSlackSettings)) { |
There was a problem hiding this comment.
seems redundant, considering we are already setting the oldSlackSettings to {} based on when templateSettingsConfig.slack is empty.
pritamstyz4ever
approved these changes
Jun 27, 2024
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users occasionally need to add more jobs to the pipeline, beyond those included in the pipeline template. Currently, this feature is not supported in the pipeline template.
Objective
This PR moves validation for user-defined jobs vs pipeline template jobs to the config-parser. Also allows users to add their own novel custom jobs.
References
Related to screwdriver-cd/screwdriver#3128, blocked by screwdriver-cd/data-schema#568
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.