Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users utilizing pipeline templates to customize image, settings, environment, and requires within the job configuration #3106

Closed
VonnyJap opened this issue May 1, 2024 · 1 comment
Assignees
Labels
pipeline-template subtask issue that is categorized as subtask of another issue
Milestone

Comments

@VonnyJap
Copy link
Member

VonnyJap commented May 1, 2024

What happened:

At present, users utilizing a pipeline template are restricted from making any modifications within the job configuration.

What you expected to happen:

Enable users to customize the customize image, settings, environment, and requires within the job configuration of pipelines that are using a template.

Given a pipeline template below:

shared:
  image: node:10
  environment:
    VAR1: "one"
    VAR2: "two"
  steps:
    - init: npm install
    - test: npm test
  settings:
    email: [test@email.com, test2@email.com]
    slack: 'mychannel'

jobs:
  main:
    requires: [~pr, ~commit]
  second:
    requires: [main]

And user defined pipeline:

template: sd-test/example-template@latest
jobs:
  main:
    requires: [~commit]
    image: node:20
    settings:
      email: [test@email.com, test3@email.com]
    environment:
      VAR3: "three"
      VAR1: "empty"

Final config should be:

jobs:
  main:
    	requires: [~commit]
        image: node:20
        steps:
            - init: npm install
            - test: npm test
        environment:
            VAR1: "empty"
            VAR2: "two"
            VAR3: "three"
        settings:
      	    email: [test@email.com, test3@email.com]
      	    slack: 'mychannel'
  second:
    	requires: [main]
        image: node:10
        steps:
            - init: npm install
            - test: npm test
        environment:
            VAR1: "one"
            VAR2: "two"
        settings:
            email: [test@email.com, test2@email.com]
            slack: 'mychannel'
@VonnyJap VonnyJap added pipeline-template subtask issue that is categorized as subtask of another issue labels May 1, 2024
@VonnyJap VonnyJap added this to the M2 milestone May 1, 2024
@VonnyJap VonnyJap changed the title Enable users utilizing pipeline templates to customize image, settings, and environment within the job configuration Enable users utilizing pipeline templates to customize image, settings, environment, and requires within the job configuration May 1, 2024
@VonnyJap
Copy link
Member Author

VonnyJap commented May 7, 2024

As of now, customization the shared config only allows customizing image, settings, and environment. When changes are made to allow customization for requires of job config in user defined pipeline, please make a change to allow the same in shared config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline-template subtask issue that is categorized as subtask of another issue
Projects
Development

No branches or pull requests

2 participants