Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate Visual Representation of Virtual Job from Normal Job #3211

Open
VonnyJap opened this issue Sep 29, 2024 · 1 comment
Open

Differentiate Visual Representation of Virtual Job from Normal Job #3211

VonnyJap opened this issue Sep 29, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@VonnyJap
Copy link
Member

What happened:

The virtual job's build console log indicated that sd-setup-init was encountering an error.

Screenshot 2024-09-29 at 12 11 27 AM

What you expected to happen:

The virtual job build log should not display a build page and should be highlighted with a different color or indicator in the workflow graph.

How to reproduce it:

Use this sample of screwdriver config

shared:
  image: node:14
  steps:
    - init: echo 'init'

jobs:
  triggering-ci:
    requires: [ ~pr, ~commit ]
  ci-setup-virtual:
    requires: [ ~triggering-ci ]
    annotations:
      screwdriver.cd/virtualJob: true
  ci-deploy:
    requires: [ ~ci-setup-virtual ]
  ci-test:
    requires: [ ci-deploy ]
  ci-certify:
    requires: [ ci-test ]
  ci-teardown-virtual:
    requires: [ ci-certify ]
    annotations:
      screwdriver.cd/virtualJob: true
  triggered-after-ci:
    requires: [ ~ci-teardown-virtual ]
@VonnyJap
Copy link
Member Author

VonnyJap commented Oct 3, 2024

To manage the visual representation of the virtual job, we've decided to:

  • Keep the build page details but exclude the steps and console.
  • Introduce a statusMessageType in the schema, marking the status of the virtual job as SUCCESS, with statusMessageType: INFO and accompanying status messages.
  • With the status, statusMessageType, and statusMessage, the UI can effectively inform users that the job is of a virtual type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

No branches or pull requests

2 participants