-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing updates to Alma Users #16
Comments
Sorry for the slow response! As for updates, the approach you choose in #17 looks good to me! It should be ok to implement for fees and fines too (except that you have to add classes for Fines). If you plan to create new things (fines or fees for instance), you may have to plow some new ground, since I don't think there's any support for creating new things in the library yet. I'm not sure what would be the best interface for that, but this could be one idea:
If you want to discuss ideas, I can try to respond a bit quicker in the future |
#17 implements updates for SMS numbers. We also anticipate submitting a PR for additions/updates for temporary addresses and updates to fines/fees. These will likely come over the next month. |
@danmichaelo , #20 refactors updates for SMS numbers into general Contact Info updates. |
Love this client SDK so far, but I need to be able to perform an update to the User. I've forked the client and plan to add this feature locally and then via pull request.
Do y'all have any preferences/requirements as to how this is implemented?
I'm up for adding dedicated helper methods ala
$bib->record->appendField()
, or just adding support via theUsers
class toupdate( $identifier, $json )
orupdate( $identifier, $User)
orstore( $User )
.In particular, we will immediately be targeting updating Addresses and Fines/Fees.
@danmichaelo ?
The text was updated successfully, but these errors were encountered: