-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrast-agnostic model on a lumbar SCI patient outputs incorrect segmentation #118
Comments
Even though the these datasets were used for training (including SCI and lumbar datasets), I think that the subject above is a corner case (i.e. lumbar SCI with metal hardware) and is quite difficult to segment given that we don't have that many lumbar scans and scans with hardware (compared to healthy and MS subjects). Therefore, one possible option I recommend is to consider also using the Reason: It is difficult for one model to be able to reliably segment any cord, given the heterogeneity in the scans, resolutions and image quality. So, if a user has a challenging test case (like the one @valosekj had), we could ask the user to also consider trying |
@naga-karthik do you think we should consider adding this dataset in the contrast-agnostic model? if it makes the model more "agnostic" to pathologies, then it's a big plus for that model. Ultimately, the more cases it can cover, the more it will be used (and cited). |
hey @jcohenadad, are you referring to a particular dataset? Maybe I'm missing something, here are the datasets currently included in the model training. |
Thanks for the clarification, Naga! I probably introduced some confusion here during yesterday's meeting, as I thought that only SCIsegV2 included the |
[IMPORTANT] hey @valosekj, I made a mistake! Turns out that SCI datasets were not included in the contrast-agnostic v2.4 version. For reference, here's a summary of what datasets were included! Datasets used in v2.4Datasets used (n=7):
Training/Validation/Test splits across all datasets:
Training/Validation/Test across each contrast (n=9):
Model name for internal/dev purposes:
I was losing track of what datasets were being added in each release so I create a summary like the one above and upload it with every release. They can found in That said, the current un-released version of the model is trained on all SCI datasets and the DCM datasets. Would you like to try it out internally on the same subject (linked in my 1st comment)? I sent the location on the latest model on Slack. |
I went ahead and tested the latest model (v2.5) on the same subject. The issue is only partly resolved. With the latest model, we don't get any segmentations outside the SC (as reported in the original issue -- see screenshot in this comment) but the model is still unable to segment the cord at the site of the implant. I tested the model on T1w and ax_T2w images as well. The model does slightly better on T1w (at least we see some prediction after the implant) for ax_T2w it works perfectly fine! I know that this does not resolve the issue as far as computing |
I found something interesting, thank to @valosekj ! My testing script by default had the keep-largest-component enabled. As a result, we lost some prediction after the metal implant. When I re-tested by keeping everything, we have a better prediction now. (and there are still no predictions outside the cord) disabling keep-largest-componentyellow: prediction with the largest component @valosekj I think you can maybe try it on a few other subjects? Please keep in mind the train/test split used for sci-zurich. You might see a difference in performance if you're running it on the entire dataset depending on which subjects were included in training/testing. |
@naga-karthik this shows the importance of creating a script that automatically fetches the dataset and generate a log listing the data used to produce the release. How can everyone be sure that the manually created file |
oops, sorry for the misunderstanding! I am not doing this manually! it's automatically output from this function when I start the training and the output is stored in the results folder (which is simply uploaded to the GH release) :) |
Thanks for digging in, @naga-karthik!
UPDATE: v2.4.1-beta pre-release created --> Jan TODO: test it on |
@valosekj can I close this issue? |
@valosekj tried the
contrast-agnostic
v2.4 model on a lumbar SCI patient from thesci-zurich
dataset. The model even segmented regions outside the cord.RESULTS FROM contrast-agnostic model (version: 2.4)
Segmentation outside of the cord:
Undersegmented cord at the level of the lesion:
red - lesion
blue - cord
Issue: the cord should cover also the region at and below the lesion
The text was updated successfully, but these errors were encountered: