Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graph showing intra-subject variability (COV) as a function of atrophy estimation error #87

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

PaulBautin
Copy link
Collaborator

@PaulBautin PaulBautin commented Oct 25, 2020

I have opened this PR to present code used to generate figures in issue #86.

DONE:

  • Added graphs showing intra-subject variability (COV) as a function of atrophy estimation error
  • save output dataframes in a csv files

Fixes #86

- removed subjects with missing CSA
- added csv files for output dataframes
@PaulBautin
Copy link
Collaborator Author

The following graphs are briefly introduced in the supplementary material of the manuscript and are only used to prove some of are hypotheses wrong. Should they be kept and merged? @jcohenadad
(Note: the results represented here are not the the results that will be published)
fig_err_in_function_of_cov

The following graph shows the non-correlation of t1w outliers (red dots) and t2w outliers (green dots)
fig_err_in_function_of_cov_outlier

@jcohenadad
Copy link
Member

Should they be kept and merged?

hum... good question... just to be sure: you're talking about the additional functions (error_function_of_intra_cov*), right? I think it doesn't hurt to keep them in the main branch. The functions are well documented, and pretty "standalone". What do you think?

@PaulBautin
Copy link
Collaborator Author

Indeed, I am talking about the additional functions (error_function_of_intra_cov*). I agree that it would not hurt to keep these new functions in the main branch -- even more so because they are optional when running csa_rescale_stat.py.

In last commit ae45092, I have removed the following feature because it has become obsolete (there are no more missing CSAs).

* Test removing subjects with missing CSA: Presently if CSA is not computed the vertebrae levels are removed from the dataframe, I tried to see what happens when the entire subject is removed. It seems to eliminate values with high COV and low error % improving the correlation between these two metrics.

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! great addition

@PaulBautin PaulBautin merged commit 12bd8e3 into master Jan 16, 2021
@PaulBautin PaulBautin deleted the stat_cov_err branch January 16, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add graph showing intra-subject variability (STD) as a function of atrophy estimation error
2 participants