fix: functions that return promises should be async

scttcper · Jul 19, 2019 · 1504b66 · 1504b66
1 parent 1e9a0af
commit 1504b66
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -1,10 +1,11 @@
+/* eslint-disable require-atomic-updates */
 import logger from 'debug';
 import ms from 'ms';
 import { RedisClient } from 'redis';
 
 const debug = logger('koa-simple-ratelimit');
 
-function find(db: RedisClient, p: string): Promise<string> {
+async function find(db: RedisClient, p: string): Promise<string> {
   return new Promise((resolve, reject) => {
     db.get(p, (err, reply) => {
       if (err) {
@@ -16,7 +17,7 @@ function find(db: RedisClient, p: string): Promise<string> {
   });
 }
 
-function pttl(db: RedisClient, p: string): Promise<number> {
+async function pttl(db: RedisClient, p: string): Promise<number> {
   return new Promise((resolve, reject) => {
     db.pttl(p, (err, reply) => {
       if (err) {

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -261,7 +261,7 @@ describe('ratelimit middleware', () => {
         .end(done);
     });
 
-    it('should not limit if `id` returns `false`', () => {
+    it('should not limit if `id` returns `false`', async () => {
       const app = new Koa();
 
       app.use(
@@ -290,7 +290,7 @@ describe('ratelimit middleware', () => {
         }),
       );
 
-      app.use((ctx, next) => {
+      app.use(async (ctx, next) => {
         ctx.body = ctx.request.header.foo;
         return next();
       });