Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.x+ compatibility #80

Open
Zethson opened this issue Oct 21, 2024 · 2 comments
Open

Numpy 2.x+ compatibility #80

Zethson opened this issue Oct 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Oct 21, 2024

Description of feature

Hi,

the CI and therefore users currently install numpy 1.26 because https://github.com/eyurtsev/fcsparser is not numpy 2.0.0 compatible and therefore readfcs isn't either.

What is the longterm plan here? https://github.com/eyurtsev/fcsparser is not maintained anymore according to the numpy 2.0.0 issue

@Zethson Zethson added the enhancement New feature or request label Oct 21, 2024
@grst
Copy link
Collaborator

grst commented Oct 21, 2024

Maybe this is a reason to switch to @whitews's FlowIO?

There has been a lengthy discussion in #47 about even moving flowutils to scverse, but it became stale at some point.

@whitews
Copy link

whitews commented Oct 22, 2024

Hi Gregor and Lukas,

FlowIO is an essential dependency of FlowKit and as such is actively maintained. I've been tempted to add NumPy as a dependency to FlowIO but felt it was best to leave it with zero dependencies for situations like this. It's purpose is to read and write FCS files and that's what it does.

If you all do choose to use FlowIO, I'd point out one caveat. Since it reads the event data exactly as it is stored in the FCS file, any gain defined by a channel (in the metadata) is not applied. This pre-processing is rather straight-forward to implement and an example of doing so can be found in the FlowKit Sample class constructor. Or, you could just use FlowKit to get this functionality of the Sample class, the transforms implemented in FlowUtils and other features.

Hope this helps,
Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants