Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to leiden #34

Open
flying-sheep opened this issue Dec 4, 2020 · 3 comments
Open

Switch to leiden #34

flying-sheep opened this issue Dec 4, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@flying-sheep
Copy link
Member

flying-sheep commented Dec 4, 2020

see scverse/scanpy#1283 (comment)

@LuckyMD we should change the tutorials instead of going back, because louvain is deprecated:

This package has been superseded by the leidenalg package and will no longer be maintained. Please upgrade to the leidenalg package.

@LuckyMD
Copy link

LuckyMD commented Dec 4, 2020

I don't mind changing the defaults in the tutorials, but I think there's also a louvain function in the leidenalg package if you don't want to change defaults just yet, but just package reliance.

@flying-sheep
Copy link
Member Author

Hmm, if we’re going to change something anyway, shouldn’t we just go with the better option?

@LuckyMD
Copy link

LuckyMD commented Dec 4, 2020

I think that's fine... we could however still wrap sc.tl.louvain to use the leidenalg implementation so that people's code still works.

@flying-sheep flying-sheep added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants