Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): scanorama notebook #80

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

ilan-gold
Copy link
Contributor

Towards #79, things need to actually be runable somewhere and this starts that process. Hopefully in the future we can cache outputs. We can also completely deprecate this notebook if we don't want to use it anymore and just redirect to https://squidpy.readthedocs.io/en/stable/notebooks/tutorials/tutorial_tangram.html

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Since this notebook isn’t high priority, no need to do the following, but this is what I spotted:

  1. I’d uncomment the commented cell and change it so only the necessary parts run, but
  2. sns.distplot is deprecated and should be replaced

@ilan-gold
Copy link
Contributor Author

Done @flying-sheep - we can merge whenever.

.gitignore Outdated Show resolved Hide resolved
@flying-sheep flying-sheep merged commit 3d663b3 into scverse:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants