Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add speed up demonstration of datashader #109

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Little benchmark to demonstrate in which cases it is helpful to use datashader to increase rendering speed

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@LucaMarconato
Copy link
Member

LucaMarconato commented Jul 31, 2024

Thanks for the PR, this is very informative! Just a few minor comments:

  • I'd remove the variables mpl_sds and ds_sds as they are not used (also, maybe you have already seen, the developers don't recommend to compute these statistics https://docs.python.org/3/library/timeit.html#timeit.Timer.repeat).
  • The empirical indication that for ~1000 polygons on datashader is faster is very useful! Could you please also add a section to check this for points and circles?

Thanks a lot!

@LucaMarconato
Copy link
Member

LucaMarconato commented Jul 31, 2024

@timtreis
Copy link
Member

timtreis commented Sep 12, 2024

We actually already seem to have that. Will try to remove the HTML logic

@timtreis
Copy link
Member

@Sonja-Stockhaus @LucaMarconato I fixed some things that were causing warnings in other notebooks. Apparently, this fixed it.

@timtreis
Copy link
Member

@Sonja-Stockhaus I modified your notebook slightly to have less redundant code. For testing I reduced the number of points. Will rerun over-night with enough Points to see the effect.

However, for merging I'd wait until your main PR is merged because I want these to be real version accessible from PyPi.
image

@LucaMarconato LucaMarconato added the documentation Improvements or additions to documentation label Sep 15, 2024
@LucaMarconato
Copy link
Member

@timtreis ready to merge??

@timtreis
Copy link
Member

Not yet. On the one hand is datashader not faster for points, so that's weird. And then I wanted to first release sonjas feature branch so that the watermark has an actual release version attached and not a GitHub commit

@timtreis timtreis added the 🎨 spatialdata-plot Related to functionality of `spatialdata-plot` label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🎨 spatialdata-plot Related to functionality of `spatialdata-plot`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants