Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New intro guide #123

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

New intro guide #123

wants to merge 8 commits into from

Conversation

ckmah
Copy link

@ckmah ckmah commented Nov 13, 2024

Create a new intro guide; the goal is to lower the barrier to entry and highlight core SpatialData framework functionality and plotting via spatialdata-plot.
Related main issue: scverse/spatialdata#748

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:15Z
----------------------------------------------------------------

rename raw_image -> dapi


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:16Z
----------------------------------------------------------------

show how to convert to pandas with compute(), also fix markdown ^


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:17Z
----------------------------------------------------------------

add note about not doing color if too many categories


melonora commented on 2024-11-27T10:13:35Z
----------------------------------------------------------------

what do you mean with this comment?

ckmah commented on 2024-11-29T07:51:46Z
----------------------------------------------------------------

ah i meant to add a note that recommends against plotting with too many categories or else rendering the legend is very slow (matplotlib). not super necessary

Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:17Z
----------------------------------------------------------------

add can use geopandas (and link) for geometric operations


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:18Z
----------------------------------------------------------------

explain what this is plotting (gene expression)


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:19Z
----------------------------------------------------------------

and cell type


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:20Z
----------------------------------------------------------------

format

sdata\

.pl.render(...)\

.plshow()


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:21Z
----------------------------------------------------------------

if have time, better more interesting polygon?


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:22Z
----------------------------------------------------------------

remove data directory


Copy link

review-notebook-app bot commented Nov 14, 2024

View / edit / reply to this conversation on ReviewNB

ckmah commented on 2024-11-14T15:23:23Z
----------------------------------------------------------------

fix markdown


@ckmah ckmah marked this pull request as ready for review November 14, 2024 16:16
Copy link
Collaborator

what do you mean with this comment?


View entire conversation on ReviewNB

Copy link

review-notebook-app bot commented Nov 27, 2024

View / edit / reply to this conversation on ReviewNB

melonora commented on 2024-11-27T10:18:01Z
----------------------------------------------------------------

Maybe for tables we could add a link to the notebook explaining them. Also, in the codebase elements are also refered to as either SpatialElement or tables. Rather than saying annotating the data we could say annotating SpatialElements or storing arbitrary metadata (note that tables do not necessarily have to annotate an element.


Copy link

review-notebook-app bot commented Nov 27, 2024

View / edit / reply to this conversation on ReviewNB

melonora commented on 2024-11-27T10:18:01Z
----------------------------------------------------------------

 for supported platforms -> for supported spatial omics platforms... perhaps doc link here


Copy link

review-notebook-app bot commented Nov 27, 2024

View / edit / reply to this conversation on ReviewNB

melonora commented on 2024-11-27T10:18:02Z
----------------------------------------------------------------

One could interpret 2D here as XY and 3D as CYX. Perhaps put it like this:

2D (cyx) or 3D (czyx) arrays where the c axis is for channels and the z,x and y axes are spatial coordinates


Copy link

review-notebook-app bot commented Nov 27, 2024

View / edit / reply to this conversation on ReviewNB

melonora commented on 2024-11-27T10:18:03Z
----------------------------------------------------------------

This method is being deprecated due to the definition being ambigious, am I getting the actual channels or the channel names. A method get_channel_names is now available, see spatialdata.models.get_channel_names — spatialdata


@melonora
Copy link
Collaborator

The plotting warnings regarding dtype should be gone by now.

@melonora
Copy link
Collaborator

Also regarding terms, might be nice to later link to the glossary, but that would be a separate issue.

Copy link
Author

ckmah commented Nov 29, 2024

ah i meant to add a note that recommends against plotting with too many categories or else rendering the legend is very slow (matplotlib). not super necessary


View entire conversation on ReviewNB

@ckmah
Copy link
Author

ckmah commented Nov 29, 2024

@melonora thanks for the review, addressed comments by compiling tutorial links in first text block as suggested. also added the notebook to the Tutorials table of contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants