-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New intro guide #123
base: main
Are you sure you want to change the base?
New intro guide #123
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:15Z rename |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:16Z show how to convert to pandas with compute(), also fix markdown ^ |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:17Z add note about not doing color if too many categories melonora commented on 2024-11-27T10:13:35Z what do you mean with this comment? ckmah commented on 2024-11-29T07:51:46Z ah i meant to add a note that recommends against plotting with too many categories or else rendering the legend is very slow (matplotlib). not super necessary |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:17Z add can use geopandas (and link) for geometric operations |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:18Z explain what this is plotting (gene expression) |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:19Z and cell type |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:20Z format sdata\ .pl.render(...)\ .plshow() |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:21Z if have time, better more interesting polygon? |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:22Z remove data directory |
View / edit / reply to this conversation on ReviewNB ckmah commented on 2024-11-14T15:23:23Z fix markdown |
for more information, see https://pre-commit.ci
what do you mean with this comment? View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB melonora commented on 2024-11-27T10:18:01Z Maybe for tables we could add a link to the notebook explaining them. Also, in the codebase elements are also refered to as either |
View / edit / reply to this conversation on ReviewNB melonora commented on 2024-11-27T10:18:01Z for supported platforms -> for supported spatial omics platforms... perhaps doc link here |
View / edit / reply to this conversation on ReviewNB melonora commented on 2024-11-27T10:18:02Z One could interpret 2D here as XY and 3D as CYX. Perhaps put it like this:
|
View / edit / reply to this conversation on ReviewNB melonora commented on 2024-11-27T10:18:03Z This method is being deprecated due to the definition being ambigious, am I getting the actual channels or the channel names. A method |
The plotting warnings regarding |
Also regarding terms, might be nice to later link to the glossary, but that would be a separate issue. |
ah i meant to add a note that recommends against plotting with too many categories or else rendering the legend is very slow (matplotlib). not super necessary View entire conversation on ReviewNB |
@melonora thanks for the review, addressed comments by compiling tutorial links in first text block as suggested. also added the notebook to the Tutorials table of contents |
Create a new intro guide; the goal is to lower the barrier to entry and highlight core SpatialData framework functionality and plotting via
spatialdata-plot
.Related main issue: scverse/spatialdata#748