Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Napari #738

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Deprecate Napari #738

merged 8 commits into from
Oct 9, 2023

Conversation

LLehner
Copy link
Member

@LLehner LLehner commented Aug 3, 2023

Add @deprecate decorator to various functions and classes.

@LLehner LLehner requested a review from giovp August 3, 2023 12:56
@giovp
Copy link
Member

giovp commented Aug 3, 2023

just seeing this, I think it's enough to just put it in the entry point so theinteractive class.

@giovp
Copy link
Member

giovp commented Oct 6, 2023

@LLehner it seems the deprecated module is missing from dependency, can you add and re-test, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #738 (8e35ba8) into main (9eca4a7) will decrease coverage by 2.30%.
The diff coverage is 38.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   72.21%   69.92%   -2.30%     
==========================================
  Files          39       39              
  Lines        5442     5476      +34     
  Branches     1019     1018       -1     
==========================================
- Hits         3930     3829     -101     
- Misses       1226     1358     +132     
- Partials      286      289       +3     
Files Coverage Δ
src/squidpy/pl/_interactive/interactive.py 54.16% <100.00%> (+3.10%) ⬆️
src/squidpy/im/_container.py 85.42% <0.00%> (ø)
src/squidpy/pl/_interactive/_widgets.py 2.43% <50.00%> (-27.89%) ⬇️
src/squidpy/_utils.py 56.29% <35.48%> (-5.38%) ⬇️

... and 3 files with indirect coverage changes

@giovp giovp merged commit 1535dcb into main Oct 9, 2023
6 of 8 checks passed
@giovp giovp deleted the deprecate_napari branch October 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants