major bug fix (even though it'll shortly be clobbered by moving from …

…child dictionaries to child sorted lists).
sdcondon · Sep 28, 2024 · 2968f12 · 2968f12
1 parent 726243a
commit 2968f12
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/....Tests/SentenceManipulation/VariableManipulation/VariableUnifyingEqualityComparerTests.cs b/....Tests/SentenceManipulation/VariableManipulation/VariableUnifyingEqualityComparerTests.cs
@@ -23,7 +23,7 @@ public class VariableUnifyingEqualityComparerTests
                 X: P(F(X), F(Y)),
                 Y: P(F(Y), F(X))),
 
-            new( // todo: passes only because the tests standardise the vars as part of tocnf.
+            new(
                 X: P(X, Y, Z),
                 Y: P(Y, Z, X)),
         ])

diff --git a/...CFirstOrderLogic/ClauseIndexing/AsyncFeatureVectorIndexDictionaryNode{TFeature,TValue}.cs b/...CFirstOrderLogic/ClauseIndexing/AsyncFeatureVectorIndexDictionaryNode{TFeature,TValue}.cs
@@ -70,7 +70,7 @@ public async IAsyncEnumerable<KeyValuePair<KeyValuePair<TFeature, int>, IAsyncFe
     /// <inheritdoc/>
     public ValueTask<IAsyncFeatureVectorIndexNode<TFeature, TValue>> GetOrAddChildAsync(KeyValuePair<TFeature, int> vectorComponent)
     {
-        IAsyncFeatureVectorIndexNode<TFeature, TValue> node = new AsyncFeatureVectorIndexDictionaryNode<TFeature, TValue>();
+        IAsyncFeatureVectorIndexNode<TFeature, TValue> node = new AsyncFeatureVectorIndexDictionaryNode<TFeature, TValue>(childrenByVectorComponent.Comparer);
         if (!childrenByVectorComponent.TryAdd(vectorComponent, node))
         {
             node = childrenByVectorComponent[vectorComponent];

diff --git a/src/SCFirstOrderLogic/ClauseIndexing/FeatureVectorIndexDictionaryNode{TFeature,TValue}.cs b/src/SCFirstOrderLogic/ClauseIndexing/FeatureVectorIndexDictionaryNode{TFeature,TValue}.cs
@@ -55,7 +55,7 @@ public IFeatureVectorIndexNode<TFeature, TValue> GetOrAddChild(KeyValuePair<TFea
     {
         if (!childrenByVectorComponent.TryGetValue(vectorComponent, out var node))
         {
-            node = new FeatureVectorIndexDictionaryNode<TFeature, TValue>();
+            node = new FeatureVectorIndexDictionaryNode<TFeature, TValue>(childrenByVectorComponent.Comparer);
             childrenByVectorComponent.Add(vectorComponent, node);
         }