Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Haml > 6.1 #447

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Allow Haml > 6.1 #447

merged 2 commits into from
Oct 2, 2023

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Oct 1, 2023

Add Haml 6.2 compatibility

Remove upper version constraint to allow any version of Haml.

Haml-lint will break if the loaded Haml version is not supported, but this
change will allow developers to update the production library and decide how
to take action on the linter later.

Also fixes 6.1 appraisal file.

Close #446


Also bumps rubocop and removes an outdated comment

@tagliala
Copy link
Contributor Author

tagliala commented Oct 1, 2023

Failures do not depend by these changes, see #445

@tagliala tagliala changed the title Allow Haml 6.2 Allow Haml > 6.1 Oct 1, 2023
@sds
Copy link
Owner

sds commented Oct 2, 2023

Thanks @tagliala. Can we rebase on top of the fix for #445?

Remove upper version constraint to allow any version of Haml.

Haml-lint will break if the loaded Haml version is not supported, but this
change will allow developers to update the production library and decide how
to take action on the linter later.

Also fixes 6.1 appraisal file.

Close sds#446
1.56.x does not support Ruby 2.6

Failures do not depend by this change, see sds#445
@sds sds merged commit 6695363 into sds:main Oct 2, 2023
34 checks passed
@tagliala tagliala deleted the feature/allow-haml-62 branch October 2, 2023 15:36
@tagliala tagliala mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to Haml 6.2
2 participants