Skydev issues110 77 #137
Skydev issues110 77 #137
Conversation
|
Oh also I tried to format the header values so they would have a limited number of decimal points. In doing so I think the values are now strings, not sure if this is important for future functions (like building the drpall file) |
python/lvmdrp/core/sky.py
Outdated
| #if telescope not in {"SKYE", "SKYW", "SCI", "SPEC"}: | ||
| # raise ValueError(f"invalid value for 'telescope' parameter: '{telescope}', valid values are 'SKYE', 'SKYW', 'SCI', or 'SPEC'") |
There was a problem hiding this comment.
If you don't need this anymore, then you can remove it
There was a problem hiding this comment.
Yep, guess I forgot that one, thanks for catching it!
There was a problem hiding this comment.
Hmm I don't see it anymore in my current version, so I think I did remove it.
|
@ajmejia @havok2063 I think this is ready to be merged now. Ran on a subset of the refdata and the drpall file looked ok |
|
Some of the CI isn't passing. See the failing checks. Can you merge the latest master into this branch? This should clear up some of them. It looks like there may be other linting issues that need to be resolved. |
updating branch to resolve potential issues
|
Looks good to me! |
|
Looks good! Thanks! |
PR to merge skydev_issues110_77 into main. I updated and re-organized the sky header keywords and comments. Still needs more testing and there are four more skymodel header keywords that need to be added (see comments in skymodel_pars_header to add moon ra, moon dec, moon phase, and moon illumination). Also should update how the drpall grabs these keywords (note the shadow_height keywords are now sh_hght, and several of the {telescope} is removed). Closes #110.