Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factoring sky subtraction module #47

Merged
merged 28 commits into from
Mar 11, 2024
Merged

Re-factoring sky subtraction module #47

merged 28 commits into from
Mar 11, 2024

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented Jan 11, 2024

Implements the following improvements into the sky subtraction module:

  • Supersky (spline-)fitting is stored in output files of interpolate_sky routine
  • Sky subtraction now happening at the end of the reduction (i.e., after flux calibration)
  • Final sky model is being propagated into lvmCFrame
  • Fixing -s flag for skipping sky subtraction (while still saving master sky)
  • Adding metadata information to sky module products (still in progress)
  • Add header keywords for sky subtraction (@ymamay 's and @kslong's requests)
  • Store flux scaling factors in table

@ajmejia ajmejia added the enhancement New feature or request label Jan 11, 2024
@ajmejia ajmejia requested review from kslong and ymamay January 11, 2024 14:30
@ajmejia ajmejia self-assigned this Jan 11, 2024
@ajmejia ajmejia marked this pull request as ready for review March 11, 2024 19:39
@ajmejia ajmejia merged commit 67aa160 into master Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants