Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing reduction sequence for twilights #48

Merged
merged 53 commits into from
Mar 6, 2024
Merged

Implementing reduction sequence for twilights #48

merged 53 commits into from
Mar 6, 2024

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented Jan 11, 2024

This branch implements the full reduction sequence of the twilight sequence in the following way:

  • It runs the preprocessing and image detrending
  • Extracts the fibers using fiber profile fitting
  • Wavelength calibrates and rectifies
  • Stacks each individual exposure spectrograph wise
  • Fits each fiber continuum with a spline to remove solar spectrum absorption features and color factor
  • Combines each exposure (camera wise) into a master RSS
  • Resamples back to native pixel scale and stores final fiberflat

The reduction of the twillight sequence is run as follows:

drp twilight -e EXP1,EXP2,...,EXPN

or

drp twilight -e EXP1,EXPN

to expand exposure numbers into a list [EXP1,EXP2,...,EXPN]. You can also pass multiple exposure number ranges

drp twilight -e EXP1,EXPN -e EXP1,EXPM

See drp twilight --help for more options

During the reduction of twilights some QA plots are produced, namely: *twilight_continuum_fit, *twilight_flatfielded and *twilight_fiberflat_fit; to show the iterative continuum fitting, the resulting flatfielded twilight and the fiberflat, respectively.

@ajmejia ajmejia added the enhancement New feature or request label Jan 11, 2024
@ajmejia ajmejia marked this pull request as ready for review February 7, 2024 13:56
@ajmejia
Copy link
Contributor Author

ajmejia commented Mar 6, 2024

There's still a remaining 3-5% systematic error when flatfielding twilight exposures using the master fiberflats created. This is shown in the following plot:

image

These systematic errors seem to be correlated with the mean count level as shown in this plot:

image

Where the colors mean the same as in the previous plot. We will fix this issue in a different PR.

@ajmejia ajmejia merged commit cf808e8 into master Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant