Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recfactoring of DRP to produce final data products #49

Merged
merged 76 commits into from
Apr 15, 2024
Merged

Recfactoring of DRP to produce final data products #49

merged 76 commits into from
Apr 15, 2024

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented Jan 11, 2024

Implementing refactoring of the DRP to naturally produce the following science products:

  • lvmFrame (extracted, wavelength-calibrated, and spectrograph-stacked, flatfielded data)
  • lvmFFrame (flux-calibrated data)
  • lvmCFrame (channel-combined, flux-calibrated data)
  • lvmSFrame (sky-subtracted data)

Main changes are:

  • Updating blueprints for final dataproducts
  • Integration of data products as classes in lvmdrp.core.rss module
  • Propagation of fiber tracing information into extracted frames (as polynomial coefficients)
  • Propagation of wavelength and LSF fittings (as polynomial coefficients)
  • Integration of RSS rectification

NOTE:

The following products will be implementing in a different PR:

  • lvmRSS (exposure-stacked data)
  • drpAll (DRP summary product)

This branch requires merging #47 and #48 first.

@ajmejia ajmejia marked this pull request as ready for review April 15, 2024 13:14
@ajmejia ajmejia merged commit 08f5fe7 into master Apr 15, 2024
8 checks passed
@ajmejia ajmejia deleted the fixdps branch April 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant