-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python 3.11 #1496
Conversation
PR is waiting on CTGAN, SDMetrics and DeepEcho releases with python 3.11. |
7aea60d
to
42f62da
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1496 +/- ##
==========================================
- Coverage 96.38% 96.31% -0.08%
==========================================
Files 49 49
Lines 3958 3962 +4
==========================================
+ Hits 3815 3816 +1
- Misses 143 146 +3
☔ View full report in Codecov by Sentry. |
sdv/multi_table/hma.py
Outdated
@@ -6,6 +6,7 @@ | |||
|
|||
import numpy as np | |||
import pandas as pd | |||
from packaging import version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid using packaging? It's not listed as an sdv dependency and is probably installed by one of the other libraries. It seems like matplotlib and plotly require it and those are also not direct dependencies for SDV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Resolve #1459.