Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discrete_detect_columns logic #1546

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Update discrete_detect_columns logic #1546

merged 3 commits into from
Aug 18, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Aug 15, 2023

Resolve #1450.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (6480f1f) 96.42% compared to head (6680d25) 96.48%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
+ Coverage   96.42%   96.48%   +0.05%     
==========================================
  Files          49       49              
  Lines        3999     4007       +8     
==========================================
+ Hits         3856     3866      +10     
+ Misses        143      141       -2     
Files Changed Coverage Δ
sdv/single_table/utils.py 87.96% <100.00%> (+2.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review August 16, 2023 02:09
@fealho fealho requested a review from a team as a code owner August 16, 2023 02:09
@fealho fealho requested review from pvk-developer, amontanez24 and R-Palazzo and removed request for a team and pvk-developer August 16, 2023 02:09
sdv/single_table/utils.py Outdated Show resolved Hide resolved
sdv/single_table/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fealho fealho merged commit 18f2c12 into master Aug 18, 2023
37 checks passed
@fealho fealho deleted the issue-1450-ctgan-bug branch August 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inefficient CTGAN modeling when adding categorical transformers
4 participants