Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preprocessing of boolean columns for CTGANSynthesizer #1547

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Aug 16, 2023

Resolve #1530.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6480f1f) 96.42% compared to head (3e79c37) 96.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1547   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          49       49           
  Lines        3999     3999           
=======================================
  Hits         3856     3856           
  Misses        143      143           
Files Changed Coverage Δ
sdv/single_table/ctgan.py 88.23% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho marked this pull request as ready for review August 16, 2023 03:23
@fealho fealho requested a review from a team as a code owner August 16, 2023 03:23
@fealho fealho requested review from frances-h and amontanez24 and removed request for a team August 16, 2023 03:23
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 📦

@fealho fealho merged commit ba6a908 into master Aug 17, 2023
37 checks passed
@fealho fealho deleted the issue-1530-ctgan-boolean branch August 17, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTGANSynthesizer is assigning LabelEncoder to boolean columns (instead of None)
4 participants