Enhance Benchmark Report Generation #2248
Open
+79
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
force-pushed
the
issue-2235-enhance-benchmark-report-generation
branch
from
31f7d63
to
40a66fa
Compare
frances-h
approved these changes
Oct 3, 2024
gsheni
reviewed
Oct 4, 2024
| @@ -39,6 +39,8 @@ jobs: | |||
| run: | | |||
| invoke benchmark-dtypes | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
Should we add a timeout-minutes to the run_dtypes_benchmark job?
There was a problem hiding this comment.
We can set it up to 20 minutes. This are the actual times for it:
PS:
The reason of the continue-on-error is to continue and generate the report even if pytest fails. That way we can then send a message on slack and update the reports marking what failed during the execution.
amontanez24
reviewed
Oct 4, 2024
| for key, value in comparison_results.items(): | ||
| if not value.empty: | ||
| sorted_results[key] = value | ||
| if key == 'unsupported_dtypes': | ||
| slack_messages.append(':fire: New unsupported DTypes!') | ||
| mark_results['#EB9999'] = value |
There was a problem hiding this comment.
minor: we should label the hex codes as constants like RED_HEX = ... or whatever it is
| # Compute the summary | ||
| summary = pd.DataFrame() | ||
| for name, df in results.items(): | ||
| df = calculate_support_percentage(df) |
There was a problem hiding this comment.
what does this df represent? Can we name it accordingly
| @@ -117,6 +133,8 @@ def save_to_gdrive(output_folder, results, output_filename=None): | |||
| output_filename (str, optional): | |||
| String representing the filename to be used for the results spreadsheet. If None, | |||
| uses to the current date and commit as the name. Defaults to None. | |||
| mark_results (dict, optional): | |||
| A dict mapping to mark the results. | |||
There was a problem hiding this comment.
mapping what to the mark?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2235
CU-86b2975ca