Change the code related to pydrive and use google-api instead
#2254
Conversation
| @@ -62,7 +62,11 @@ test = [ | |||
| 'rundoc>=0.4.3,<0.5', | |||
| 'pytest-runner >= 2.11.1', | |||
| 'tomli>=2.0.0,<3', | |||
| 'pydrive', | |||
| 'google-api-python-client', | |||
| 'google-auth', | |||
There was a problem hiding this comment.
this and google-auth-httplib2 already seem to be required by the python client
| credentials = json.loads(tmp_credentials) | ||
| creds = Credentials.from_authorized_user_info(credentials, SCOPES) |
There was a problem hiding this comment.
minor: maybe we rename the first one to credentials_json and the other to credentials or something
| @@ -25,53 +26,38 @@ def _generate_filename(): | |||
|
|
|||
|
|
|||
| def _get_drive_client(): | |||
There was a problem hiding this comment.
minor: should we rename to _get_drive_service?
| xlsx_mime = 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' | ||
| drive_file.FetchContent(mimetype=xlsx_mime) | ||
| return pd.read_excel(drive_file.content, sheet_name=None) | ||
| service = _get_drive_client() |
There was a problem hiding this comment.
should we be calling service.close() when we're done with it?
| if creds and creds.expired and creds.refresh_token: | ||
| creds.refresh(Request()) | ||
| else: | ||
| flow = InstalledAppFlow.from_client_secrets_file('client_secrets.json', SCOPES) |
There was a problem hiding this comment.
this file doesn't exist does it? Will this block ever work?
There was a problem hiding this comment.
Oh sorry this was from my local. I will remove it
There was a problem hiding this comment.
I think we can simplify the authentication section. We never authenticate by loading from a json file on the user's machine so I don't think we need that option. We can either just refresh the credentials like we do or use InstalledAppFlow.from_client_config and just load from the string
Resolves #2238
This
prchanges the usage ofpydriveto officialgoogleapi calls without the need of third party libraries likePyDrive2or the currently deprecatedPyDrive.CU-86b29t2nz