Skip to content

Commit

Permalink
Fix CI software versions (#51)
Browse files Browse the repository at this point in the history
clang-tidy 11
Sphinx 4.2
Catch 3.5.1
Latest Dragonbox (vendored)

Warnings fixes for newer toolchains
Disabled several clang-tidy checks that either break dragonbox or are buggy
  • Loading branch information
seanmiddleditch authored Jan 15, 2024
1 parent b979434 commit 7286f8b
Show file tree
Hide file tree
Showing 11 changed files with 3,098 additions and 32 deletions.
8 changes: 6 additions & 2 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,19 @@ Checks: >-
-cppcoreguidelines-pro-type-member-init,
-cppcoreguidelines-pro-type-reinterpret-cast,
-cppcoreguidelines-pro-type-union-access,
-cppcoreguidelines-pro-type-vararg,
-cppcoreguidelines-owning-memory,
-modernize-avoid-c-arrays,
-modernize-use-trailing-return-type,
-modernize-raw-string-literal,
-modernize-unary-static-assert,
-modernize-use-nodiscard,
-modernize-use-trailing-return-type,
-readability-braces-around-statements,
-readability-convert-member-functions-to-static,
-readability-else-after-return,
-readability-implicit-bool-conversion,
-readability-magic-numbers,
-readability-named-parameter,
-readability-uppercase-literal-suffix
-readability-uppercase-literal-suffix,
HeaderFilterRegex: nanofmt/.*[.]h
WarningsAsErrors: "*"
7 changes: 3 additions & 4 deletions .github/workflows/tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,17 @@ jobs:
name: Tidy

env:
CXX: clang++
BUILD_TYPE: RELEASE
CLANG_TIDY: clang-tidy-10
CLANG_TIDY: clang-tidy-11

steps:
- uses: actions/checkout@v2

- name: Install
run: sudo apt-get install -y clang-tidy-10
run: sudo apt-get install -y ${{ env.CLANG_TIDY }}

- name: Configure
env:
CXX: ${{ matrix.compiler }}
run: cmake -B ${{ github.workspace }}/build -DCMAKE_BUILD_TYPE=${{ matrix.config }} -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON

- name: Tidy
Expand Down
2 changes: 1 addition & 1 deletion cmake/fetch_catch2.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ include(FetchContent)
FetchContent_Declare(
Catch2
GIT_REPOSITORY https://github.com/catchorg/Catch2.git
GIT_TAG v3.0.0-preview3
GIT_TAG v3.5.1
)

FetchContent_MakeAvailable(Catch2)
Expand Down
9 changes: 0 additions & 9 deletions cmake/fetch_dragonbox.cmake

This file was deleted.

2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
#
# This is also used if you do content translation via gettext catalogs.
# Usually you set "language" from the command line for these cases.
language = None
language = 'en'

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
Expand Down
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
docutils==0.16
sphinx<4.1
sphinx>=4.2
sphinx-rtd-theme
Loading

0 comments on commit 7286f8b

Please sign in to comment.