Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly convert strings with to_format_string to a format_string #42

Merged
merged 1 commit into from
Jan 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/nanofmt/format.inl
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ namespace NANOFMT_NS {
template <typename T>
struct value_type_map;

template <typename T>
using enable_if_format_string =
std::enable_if_t<std::is_same_v<::NANOFMT_NS::format_string, decltype(to_format_string(declval<T>()))>>;

struct char_buffer {
char const* chars = nullptr;
std::size_t max_length = 0;
Expand Down Expand Up @@ -113,8 +117,8 @@ namespace NANOFMT_NS {
constexpr /*implicit*/ format_string(char const (&str)[N]) noexcept;
constexpr explicit format_string(char const* const zstr) noexcept;

template <typename StringT>
constexpr explicit format_string(StringT const& string) noexcept;
template <typename StringT, typename = detail::enable_if_format_string<StringT>>
constexpr /*implicit*/ format_string(StringT const& string) noexcept;

char const* begin = nullptr;
char const* end = nullptr;
Expand Down Expand Up @@ -243,7 +247,7 @@ namespace NANOFMT_NS {
: begin(zstr)
, end(begin + __builtin_strlen(begin)) {}

template <typename StringT>
template <typename StringT, typename>
constexpr format_string::format_string(StringT const& string) noexcept : format_string(to_format_string(string)) {}

template <typename StringT>
Expand Down
Loading