Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature: ikle2 / ikle3 as variable #38

Open
3 tasks
tomsail opened this issue Jun 17, 2024 · 1 comment
Open
3 tasks

add feature: ikle2 / ikle3 as variable #38

tomsail opened this issue Jun 17, 2024 · 1 comment

Comments

@tomsail
Copy link
Contributor

tomsail commented Jun 17, 2024

This feature would be handy for selecting and cropping windows of the selafin file.

See an example for crop function in Thalassa

Tasks:

  • add the 2D elements as a variable
  • add the 3D elements as a variable when dealing with a 3D Selafin
  • add the number of elements as a dimension
@tomsail tomsail mentioned this issue Jun 18, 2024
Draft
3 tasks
@tomsail
Copy link
Contributor Author

tomsail commented Jun 18, 2024

suggestion from pmav99:

  • maybe not suppress names instances ikle2/ikle3
  • add more checks and cases for if not is_2d: # if 3D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomsail