Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default build target for wasm example #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gentoli
Copy link

@Gentoli Gentoli commented Mar 7, 2023

No description provided.

@ahrnbom
Copy link

ahrnbom commented Aug 1, 2023

Shouldn't it be wasm32-unknown-emscripten? What's the difference?

@Gentoli
Copy link
Author

Gentoli commented Aug 2, 2023

@ahrnbom looks like wasm32-unknown-unknown is used more with wasm-bindgen/wasm-pack (https://rustwasm.github.io/wasm-bindgen/reference/rust-targets.html). From what I see online wasm32-unknown-emscripten would provide/translate machine APIs to wasm. This is not needed here.

@ahrnbom
Copy link

ahrnbom commented Aug 3, 2023

Now I'm even more confused. The example README only mentions building with Trunk, and nothing about wasm-pack. If wasm-pack is an alternative to Trunk, which works with Kiss3D, I think this should be mentioned in the Readme for the WASM example

@Gentoli
Copy link
Author

Gentoli commented Aug 3, 2023

@ahrnbom wasm-bindgen/wasm-pack are used to generate javascript bindings/package for scripts in html to load/call rust wasm. trunk is similar to webpack that bundles the generated javascript so it's more compact for web.

wasm-pack is not an alternative. I only mentioned that because it's from rustwasm working group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants