Don't crash on invalid certificates (TLS) (#4494)

secdev · Sep 3, 2024 · 5c7b694 · 5c7b694
1 parent 6f0eb89
commit 5c7b694
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/scapy/layers/tls/handshake.py b/scapy/layers/tls/handshake.py
@@ -1006,11 +1006,11 @@ def post_dissection_tls_session_update(self, msg_str):
         connection_end = self.tls_session.connection_end
         if connection_end == "client":
             if self.certs:
-                sc = [x.cert[1] for x in self.certs]
+                sc = [x.cert[1] for x in self.certs if hasattr(x, 'cert')]
                 self.tls_session.server_certs = sc
         else:
             if self.certs:
-                cc = [x.cert[1] for x in self.certs]
+                cc = [x.cert[1] for x in self.certs if hasattr(x, 'cert')]
                 self.tls_session.client_certs = cc