Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import InvalidSignature from the correct location #4024

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 5, 2023

cryptography.hazmat.backends.openssl.ec was not a public API, but an implementation detail, and is likely to be removed (see pyca/cryptography#9024)

edited by gpotter2 for search purposes:

Traceback (most recent call last):
  File "<input>", line 2, in <module>
  File "/home/runner/work/cryptography/cryptography/scapy/scapy/layers/tls/handshake.py", line 42, in <module>
    from scapy.layers.tls.cert import Cert
  File "/home/runner/work/cryptography/cryptography/scapy/scapy/layers/tls/cert.py", line 51, in <module>
    from cryptography.hazmat.backends.openssl.ec import InvalidSignature
ModuleNotFoundError: No module named 'cryptography.hazmat.backends.openssl.ec'

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #4024 (a7cdb97) into master (3da71cb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.01%     
==========================================
  Files         328      328              
  Lines       75415    75415              
==========================================
- Hits        61799    61795       -4     
- Misses      13616    13620       +4     
Impacted Files Coverage Δ
scapy/layers/tls/cert.py 88.15% <100.00%> (ø)

... and 4 files with indirect coverage changes

@evverx
Copy link
Contributor

evverx commented Jun 5, 2023

I wonder if it's related to pyca/cryptography#9024 in any way? :-)

@evverx
Copy link
Contributor

evverx commented Jun 5, 2023

As far as I understand with that cryptography PR merged scapy without this patch (< 2.6) should stop working with the first version of cryptography where ec is removed. I think at least it should probably be mentioned in the commit message to make it easier for people backporting stuff to find this patch.

@alex
Copy link
Contributor Author

alex commented Jun 5, 2023

Ok, updated the description

@gpotter2 gpotter2 enabled auto-merge (rebase) June 5, 2023 21:27
@gpotter2
Copy link
Member

gpotter2 commented Jun 5, 2023

Thanks a lot for the heads-up and PR @alex !

@gpotter2 gpotter2 merged commit a45836f into secdev:master Jun 5, 2023
@alex alex deleted the patch-1 branch June 6, 2023 00:11
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants