Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more precise dissection of UDS DTCs #4094

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

polybassa
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4094 (a7c523b) into master (353b241) will decrease coverage by 1.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4094      +/-   ##
==========================================
- Coverage   81.93%   80.00%   -1.94%     
==========================================
  Files         330      330              
  Lines       76161    76174      +13     
==========================================
- Hits        62405    60944    -1461     
- Misses      13756    15230    +1474     
Files Changed Coverage Δ
scapy/contrib/automotive/uds.py 98.57% <100.00%> (+0.05%) ⬆️

... and 46 files with indirect coverage changes

@polybassa
Copy link
Contributor Author

The failing unit test is not related to this PR. @gpotter2 Can this PR please get merged?

@gpotter2
Copy link
Member

Yeah there's some weird PyPy bug.

@gpotter2 gpotter2 merged commit 070a262 into secdev:master Sep 12, 2023
16 of 18 checks passed
@polybassa
Copy link
Contributor Author

I've read the upstream documentation.. Sounds horrible

@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants