Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS server, better Automaton.spawn #4520

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 2, 2024

Various random fixes:

  • fix memory leak when using Automaton.spawn
  • add a HTTPS_Server variant of the HTTP_Server
  • fix export_object and import_object
  • fix bug in .show() in LatexTheme
  • fix NTLM SSP when against libcurl
  • drop base64_bytes from tests

scapy/layers/http.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 51.28205% with 19 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (a5dab9e) to head (5f1129c).

Files with missing lines Patch % Lines
scapy/automaton.py 55.00% 9 Missing ⚠️
scapy/layers/http.py 27.27% 8 Missing ⚠️
scapy/layers/kerberos.py 0.00% 1 Missing ⚠️
scapy/layers/ntlm.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4520      +/-   ##
==========================================
- Coverage   81.59%   81.58%   -0.02%     
==========================================
  Files         356      356              
  Lines       85215    85248      +33     
==========================================
+ Hits        69528    69546      +18     
- Misses      15687    15702      +15     
Files with missing lines Coverage Δ
scapy/themes.py 91.46% <ø> (ø)
scapy/utils.py 73.41% <100.00%> (-0.04%) ⬇️
scapy/layers/kerberos.py 67.43% <0.00%> (ø)
scapy/layers/ntlm.py 87.29% <66.66%> (-0.10%) ⬇️
scapy/layers/http.py 82.34% <27.27%> (-1.05%) ⬇️
scapy/automaton.py 75.00% <55.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 6f0eb89 into secdev:master Sep 2, 2024
1 check was pending
@gpotter2 gpotter2 deleted the win-minor-fixes branch September 2, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant