Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check LDAP fields #4524

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Check LDAP fields #4524

merged 1 commit into from
Sep 5, 2024

Conversation

guedou
Copy link
Member

@guedou guedou commented Sep 5, 2024

This fixes an issue reported by OSS-Fuzz. Please merge it ASAP.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (45ea41a) to head (57cce28).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4524      +/-   ##
==========================================
+ Coverage   79.66%   81.61%   +1.94%     
==========================================
  Files         356      356              
  Lines       85255    85577     +322     
==========================================
+ Hits        67920    69845    +1925     
+ Misses      17335    15732    -1603     
Files with missing lines Coverage Δ
scapy/layers/ldap.py 54.24% <100.00%> (+0.16%) ⬆️

... and 47 files with indirect coverage changes

scapy/layers/ldap.py Outdated Show resolved Hide resolved
@guedou guedou force-pushed the guedou/20240905/oss-fuzz_ldap branch from 03164c7 to 57cce28 Compare September 5, 2024 20:05
@gpotter2 gpotter2 enabled auto-merge (squash) September 5, 2024 20:32
@gpotter2 gpotter2 merged commit 1935723 into master Sep 5, 2024
25 checks passed
@gpotter2 gpotter2 deleted the guedou/20240905/oss-fuzz_ldap branch September 5, 2024 21:15
@@ -2338,6 +2338,11 @@ except Scapy_Exception:
file = BytesIO(b"\n\r\r\n\x00\x00\x008\x1a+<M\x00\x01\x00\x00\xef\xff\xff\x81\x01\x00\x00\x01\x00\x00\x00\x0c\x00\x00\x00\x00\x00\x00\x00\x009\x00\x00\x00\x01\x00\x00\x000\x00e\x00\x00\x00\x00\x00\x00\x00\x008\x00\x00\x00\x06\x00\x00\x00d\x00\x00\x00\x00'\x00\x00\x00\x01\x00\x00\x08\x00\x00\x00\x00\x00\x00\x00\x00\x80\x01\x00\x00\x000\x00\x00\x00\x01\x00\x00\x008\x00\x00\n\x0c\x00A\x05\xc0\x01\x00\x00\x00\x00\x00d\x00\x00\x00\x00\x00\x00\x00\x00\x000\x00\x00\x00\x01\x00\x00\x008\x00\x00\n\x0c\x00A\x05\xc0\x83\x00\x00\x043\x01\x00\x00\x00\x00\x00d\x00\x00\x00\x00d")
l = rdpcap(file)

# Issue #69628
file = BytesIO(b"M<\xb2\xa1 \x00\xff\xf9\xff\x00\x00\xff\xff\xff\xa1\xb2<M\x01\x00\x00\x00\x00\x00\x00\x17\xca\xca\xca\xca\xca\xca\xca\xca\xca\xca\r\x80\x01[\x00\x01noenum\x00\x00\x00\x00\x00\x06value\x01\x00\x00\x00\x00\x00\x00\x01\x85\xff\xff\x00\x00\x94\xc3\x000\x00\x08\xa0\xf30\x800\x000\x00")
l = rdpcap(file)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test fails on 32-bit machines: #4527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants