Small optimization of cache during parsing #4526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an optimization of the caching system when dissecting packets, by skipping the initialization of fields whose only usage is for build. This only has a real effect in very specific cases, such as a succession of many payloads containing mutable values (what you'd find with
LDAP
orDot11
). In those cases however, the improvement is substantial.The packet below is an extreme case, in which the dissection time is ~60% of the previous one. Expect only a few percents, if any improvement, in other real-world uses.
Full packet