Update mpint_field and arg_kv (#175)

* Update mpint_field.cc * Update arg_kv.h * Update arg_kv.h * Update arg_kv.cc * Update arg_kv.h
secretflow · Dec 20, 2023 · 0610185 · 0610185
1 parent 2b7d888
commit 0610185
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/yacl/math/galois_field/mpint_field/mpint_field.cc b/yacl/math/galois_field/mpint_field/mpint_field.cc
@@ -87,7 +87,6 @@ void MPIntField::NegInplace(MPInt *x) const {
   WEAK_ENFORCE(IsInField(*x), "x is not a valid field element, x={}", *x);
   x->NegateInplace();
   AddInplace(x, mod_);
-  x->DecrOne();
 }
 
 MPInt MPIntField::Inv(const MPInt &x) const { return x.InvertMod(mod_); }

diff --git a/yacl/utils/spi/argument/arg_kv.cc b/yacl/utils/spi/argument/arg_kv.cc
@@ -20,12 +20,12 @@ const std::string& SpiArg::Key() const { return key_; }
 
 bool SpiArg::HasValue() const { return value_.has_value(); }
 
-SpiArg SpiArg::operator=(const char* value) {
+SpiArg& SpiArg::operator=(const char* value) {
   value_ = absl::AsciiStrToLower(std::string(value));
   return *this;
 }
 
-SpiArg SpiArg::operator=(const std::string& value) {
+SpiArg& SpiArg::operator=(const std::string& value) {
   value_ = absl::AsciiStrToLower(value);
   return *this;
 }

diff --git a/yacl/utils/spi/argument/arg_kv.h b/yacl/utils/spi/argument/arg_kv.h
@@ -39,14 +39,14 @@ class SpiArg {
   }
 
   template <typename T>
-  SpiArg operator=(const T &value) {
+  SpiArg &operator=(const T &value) {
     value_ = value;
     return *this;
   }
 
   // Specialized functions of operator=<T>
-  SpiArg operator=(const char *value);
-  SpiArg operator=(const std::string &value);
+  SpiArg &operator=(const char *value);
+  SpiArg &operator=(const std::string &value);
 
   const std::string &Key() const;
   bool HasValue() const;