Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace git_repository with http_archive #193

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Replace git_repository with http_archive #193

merged 3 commits into from
Jan 4, 2024

Conversation

anakinxc
Copy link
Collaborator

@anakinxc anakinxc commented Jan 4, 2024

No description provided.

@anakinxc anakinxc requested review from Jamie-Cui, 6fj and tongke6 January 4, 2024 09:12
tongke6
tongke6 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@tongke6 tongke6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jamie-Cui
Jamie-Cui approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@Jamie-Cui Jamie-Cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakinxc anakinxc merged commit 5feaa30 into main Jan 4, 2024
6 checks passed
@anakinxc anakinxc deleted the xc/deps branch January 4, 2024 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tongke6 tongke6 tongke6 approved these changes

@Jamie-Cui Jamie-Cui Jamie-Cui approved these changes

@6fj 6fj Awaiting requested review from 6fj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakinxc @Jamie-Cui @tongke6