Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Commit

Permalink
Merge pull request #73 from secureCodeBox/develop
Browse files Browse the repository at this point in the history
Release 1.0.1
  • Loading branch information
rseedorff authored Mar 20, 2019
2 parents 45676ee + e2b7d11 commit 33141c0
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 1 deletion.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ To build the docker image run:

`docker build -t IMAGE_NAME .`

## Generating the API Docs

1. Run the Test Suite using the `docs` maven profile: `mvn test -P docs`. This should generate a `swagger.json` file in the target folder of the `scb-engine` module.
2. Run the `swagger2markup:convertSwagger2markup` plugin: `mvn -P docs swagger2markup:convertSwagger2markup`. This should generate a file located `docs/api-doc.md` in the target folder of the `scb-engine` module.
3. Copy the `api-doc.md` file to the user guide of the [secureCodeBox](https://github.com/secureCodeBox/secureCodeBox) repository.
4. Re Add the first disclaimer paragraph pointing the users to the dynamic swagger docs of their engine. This has to be added by hand as it is not included in the export.
5. (Optional) Reformat the generated markdown file with prettier to improve the generated markdown output.

# Guidelines & Standards
Well boring yes - but please read our [guidelines and naming standards][scb-developer-guidelines].

Expand Down
16 changes: 16 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,22 @@
</pluginManagement>
</build>

<pluginRepositories>
<pluginRepository>
<id>jcenter-snapshots</id>
<name>jcenter</name>
<url>http://oss.jfrog.org/artifactory/oss-snapshot-local/</url>
</pluginRepository>
<pluginRepository>
<id>jcenter-releases</id>
<name>jcenter</name>
<url>http://jcenter.bintray.com</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>

<repositories>
<repository>
<id>camunda-bpm-nexus</id>
Expand Down
18 changes: 18 additions & 0 deletions scb-engine/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,29 @@
<properties>
<activatedProfiles>docs</activatedProfiles>
</properties>

<pluginRepositories>
<pluginRepository>
<id>jcenter-snapshots</id>
<name>jcenter</name>
<url>http://oss.jfrog.org/artifactory/oss-snapshot-local/</url>
</pluginRepository>
<pluginRepository>
<id>jcenter-releases</id>
<name>jcenter</name>
<url>http://jcenter.bintray.com</url>
<snapshots>
<enabled>false</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>

<build>
<plugins>
<plugin>
<groupId>io.github.swagger2markup</groupId>
<artifactId>swagger2markup-maven-plugin</artifactId>
<version>1.3.7</version>

<configuration>
<swaggerInput>${project.build.directory}/swagger.json</swaggerInput>
Expand Down
2 changes: 1 addition & 1 deletion scb-persistenceproviders/s3-persistenceprovider/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>aws-java-sdk-s3</artifactId>
<version>1.11.424</version>
<version>1.11.453</version>
</dependency>
<dependency>
<groupId>org.powermock</groupId>
Expand Down

0 comments on commit 33141c0

Please sign in to comment.