-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android13 QPR2 Dependency & Misc Updates #526
Android13 QPR2 Dependency & Misc Updates #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also rebuild android.jar
and libcore.jar
749d0ad
to
f81ca67
Compare
I'd like to do a bit of quick testing with this but otherwise it all looks good. |
yeah I'd be most worried about the room upgrade to not affect our K/V DB updates. |
The libs versions seem to be the same in the latest QPR3 |
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
* Ensure every plugin is present in project's plugin block with version * Switch to full plugin id for jetbrains plugins * Move plugin and dependency repos to settings Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
f81ca67
to
4348627
Compare
Rebased to fix conflicts |
4348627
to
f81f999
Compare
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
73f991f
to
07f6654
Compare
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
w: Argument -Xopt-in is deprecated. Please use -opt-in instead w: C:\Users\aayus\StudioProjects\seedvault\storage\demo\src\main\java\de\grobox\storagebackuptester\restore\DemoSnapshotFragment.kt: (34, 31): 'onBackPressed(): Unit' is deprecated. Overrides deprecated member in 'androidx.core.app.ComponentActivity'. Deprecated in Java w: Argument -Xopt-in is deprecated. Please use -opt-in instead w: C:\Users\aayus\StudioProjects\seedvault\storage\lib\src\main\java\org\calyxos\backup\storage\backup\BackupService.kt: (35, 9): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API. w: C:\Users\aayus\StudioProjects\seedvault\storage\lib\src\main\java\org\calyxos\backup\storage\restore\RestoreService.kt: (49, 9): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
If you're using Android plugin for Gradle 3.0.0 or higher, your project automatically uses a default version of the build tools that the plugin specifies Ref: https://developer.android.com/tools/releases/build-tools Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Fixes compilation on M1 macOS. Check grpc/grpc-java#7690 for further info Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Required by new AGP versions Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Tests are Gradle-only and keeping this in manifest results in namespace collision Ref: https://developer.android.com/build/configure-app-module#change-namespace-for-testing Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
07f6654
to
d51509a
Compare
Bumped AGP and Gradle to 8.x, ktlint to latest stable version and other changes to accommodate them |
Disable new R8 mode and resource namespacing for now to avoid build failures. These needs to be worked on before they can be enabled. Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
d51509a
to
6ca1f27
Compare
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
4d7daeb
to
63bfb6b
Compare
So this forces me to use JDK 17 and AS Giraffe I guess :/
|
So after upgrading my local setup, building it and running tests works here. However, there's an issue with the gradle build light theme where the action bar is all black including the text. |
@grote it seems to be unrelated to this MR. I tried looking and it seems the aforementioned issue is coming from the fact that colors defined for light theme here are using system colors while dark theme colors here simply use a properly defined color. I am unsure why it was done that way but maybe we can handle that in a different MR? |
Issue to keep track: #549 |
This PR updates dependencies to the latest release (as per AOSP and Gradle) wherever possible.