Show full URL in settings when WebDAV is used #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had that thought at first too, but then I'd say it'd be better to put function over form, show this now, and figure out a better way to tweak this change later if wanted. |
chirayudesai
previously approved these changes
Jun 18, 2024
t-m-w
previously approved these changes
Jul 3, 2024
chirayudesai
dismissed stale reviews from t-m-w and themself
The base branch was changed.
|
Bump! |
t-m-w
previously approved these changes
Oct 15, 2024
grote
force-pushed
the
690-webdav-info
branch
from
8e92d3c
to
f52b100
Compare
|
I resolved a conflict. @t-m-w does this still work as expected? |
t-m-w
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing just the host is good for most people, I'd say and showing the full path may be ugly and un-needed in case of Nextcloud, so not sure this change is good.
Fixes #690